b-jazz's Comments
Changeset | When | Comment |
---|---|---|
169421198 | about 1 month ago |
When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. |
169411507 | about 1 month ago |
When drawing golf course areas (i.e. greens, fairways, bunkers, tees, etc.), please be aware that the ways (lines) used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green. There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. When drawing these shared nodes, editors like iD will "snap" to an existing node if you get close enough. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. Thanks. |
169365241 | about 1 month ago | Thanks. I appreciate the effort. However, if you are unable to make sure every node snaps, it might be better if you just leave it as is and wait for me to get around to cleaning it up (since I will have to clean up yours as well.) You might as well save yourself the effort if it will just be changed shortly. I have fixed about 20,000 of those fairways so far this year and have about 10,000 more to go. |
169350987 | about 1 month ago |
Please don't share the nodes of the green if you have the fairway surrounding the green. If you can't see any fringe around the green, you should make the fairway butt up to the green and share the nodes on the boundary *between* the green and fairway instead. Please read the wiki for visual examples and instructions on how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please let me know and I'll gladly help clarify things. Thanks! |
169365241 | about 1 month ago |
Hey there Camel, thanks for helping out with my golf course mapping challenge. I appreciate you lending a hand. I wanted to let you know though, when you are drawing the nodes between the fairway and the green, you need to make sure every node is shared on the boundary. iD should "snap" the line when you get near the other existing node. If you don't do this, it will trigger a Q/A check for "overlapping" features. If this doesn't make sense, let me know and I'll try to clarify. Thanks! |
169302106 | about 1 month ago |
When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green. (The same can be said about fairways and bunkers, tees, roughs, etc.) There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. |
169261967 | about 1 month ago |
When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the ways used to outline those areas can't cross over each other. Fairway outlines shouldn't cross over greens or bunkers or other fairways for example. If you could go back and clean up where you've made this mistake, that would be helpful. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. |
169248708 | about 1 month ago |
FYI, you added the fairway tag to the way mentioned above, but that was unnecessary (and wrong) since the combination of the fairway and green were already correctly tagged in the multipolygon relation. Please be careful when tagging ways that belong to a relation. It's often the case that the relation defines the object, instead of the components. Thanks. |
169118861 | about 1 month ago | I wouldn't say you're "responsible" necessarily, but it sure would be appreciated if you did introduce quality errors like overlaps into the map. |
169175639 | about 1 month ago |
Hey there Max, There were a few problems with this change that I will fix but wanted you to be aware of in hopes you avoid them in the future. * Around the hole listed above, the tee box to the West of that rough had a golf=hole way that had two nodes in the tee box. The typical way to map a hole line is to just map from the farthest tee.
As I mentioned, I've corrected all these, but just wanted you to be aware. Thanks. |
169118861 | about 1 month ago |
When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the lines used to outline those areas are not allowed to cross over each other. Fairway outlines shouldn't cross over greens or bunkers for example. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. |
169083805 | about 1 month ago |
When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the lines used to outline those areas can't cross over each other. Fairways outlines shouldn't cross over greens or bunkers or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green. (The same can be said about fairways and bunkers, tees, roughs, etc.) There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. |
169077720 | about 1 month ago |
When drawing golf course areas (such as greens, fairways, bunkers, tees, etc.), please be aware that the lines used to outline those areas can't cross over each other. Fairways outlines shouldn't cross over greens or bunerks or other fairways for example. Take a look at osm.wiki/File:Golf.png for an example of the "Wrong" way to map a fairway and a green. (The same can be said about fairways and bunkers, tees, roughs, etc.) There are some cases where a fringe exists around a green and you should draw the fairway outline completely around a green. Other times, the fairway and green butt up against each other. In that case the fairway and green should share the same nodes at the boundary between the two. If you could go back and clean up where you've made this mistake, that would be great. But more importantly, if you could stop from doing this in the future, it would be greatly appreciated. If you have any questions about golf course mapping, feel free to reach out. |
169159391 | about 1 month ago | sorry |
168982538 | about 1 month ago | Hey there dirty, On the 7th hole, you broke the relation between the fairway and the inner "bunker" (looks more like a rough with the trees there, but that's irrelevant). I'm trying to make sure relations like this don't get broken so I wanted to reach out and work with people that make these edits. Were you aware that you were messing with the relation? What did you think was wrong with the way things were mapped previously? Thanks.
|
169038944 | about 1 month ago |
Please don't share the nodes of the green if you have the fairway surrounding the green. If you can't see any fringe around the green, you should make the fairway butt up to the green and share the nodes on the boundary *between* the green and fairway instead. Please read the wiki for visual examples and instructions on how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please let me know and I'll gladly help clarify things. Thanks! |
168943744 | about 1 month ago | Digress away! I've focused my attention this year on cleaning up all fairway/green overlaps. I've probably tackled 12,000+ instances so far this year and am exhausted. I have about 8,000 to go. I've also set up daily diffs so I can catch people making these "mistakes" early on so that they don't spread. You can see some of my progress on my maproulette challenge: https://maproulette.org/browse/challenges/50926. You're right that the partial overlaps are evil and need to be wiped off the map. I don't quite understand all of the math/geometry theories behind it, but somehow it is "cleaner" to have it drawn as two fairway parts instead of a single one. Ideally, the grounds crew would leave a fringe around the green and you can just draw the fairway all the way around the green and leave a gap. At that point, a multipolygon is the cleanest representation. Thanks again for the assist. |
168982148 | about 1 month ago |
Hi Mezzy, Can you please help me understand what you're trying to do with this golf course? It appears that you are simply tracing existing objects (fairways) and creating duplicate objects. I'm going to revert your changes, but want to check in with you so I can understand and help you achieve what you set out to do, but in a way that is compatible with OSM practices. Thanks! |
168943744 | about 1 month ago | Hey there CurlingMan13, Thanks for helping clean up golf courses. FYI, you can't share fairway nodes with the green nodes when you have a fairway before and after a hole like the fourth hole in this changeset. Something about it not being a mathematically simple geometry. Some editors (JOSM in particular) will warn you against that type of edit, but I guess iD doesn't. I've gone ahead and fixed it up here (osm.org/way/1415176817) for you but wanted you to be aware for future edits where the green doesn't have a clear fringe around it. Thanks. |
154284461 | about 1 month ago | Please don't draw cart paths as areas. Thanks. |