OpenStreetMap logo OpenStreetMap

Changeset When Comment
162680020 6 months ago

No worries. Thanks for responding! I’m always here to answer golf course mapping questions. The best place to start is the following wiki: osm.wiki/Tag:leisure%3Dgolf_course

Can you leave a comment here about which fairway you are getting that error on? You should be able to get a link to that specific option on the bottom of the left sidebar. Or could be that the fairway and green intersect each other. That is the most common problem and needs to be addressed first before grouping them.

162718451 6 months ago

Instead of adding "surface=grass", you should *replace* "landuse=grass" with "surface=grass".

osm.wiki/Tag:leisure%3Dgolf_course#Features_within_a_golf_course

162710716 6 months ago

Fairways and greens shouldn't intersect. To properly map them, please see examples on the golf course wiki, paying close attention to the "common pitfalls" section towards the end. Thanks.

osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls

162719448 6 months ago

FYI, things like cart paths (and most other golf course features) don't have names. To add a "name=Cart Path" tag is incorrect. Just tag it with "golf=cartpath" along with "highway=path" instead.

162680020 6 months ago

Hey there Jpipe323,

Thanks for your contributions to golf courses on OSM. We appreciate the efforts.

I was wondering if I could ask a small favor in case you continue to map golf courses. When you draw a fairway like osm.org/way/1361016157, could you select both the fairway and the green and combine them into a single object (called a multipolygon) by pressing "C" on the keyboard or right clicking and selecting "Merge". That would save me the effort of coming back at a later date and making that change myself. Thanks!

162680914 6 months ago

Hi there AsYouAre,

Just wanted to let you know that a change you made to osm.org/way/918883786 was incorrect. You tagged the outer ring that defines the fairway as "golf=fairway", but it was already part of a multipolygon that correctly defined that. To add that tag when it already existed is saying that everything inside that polygon is fairway, including the green, which isn't correct. I'll fix it. I just wanted to let you know so you could avoid that in the future.

162613403 6 months ago

Thanks djjherp for contributing golf courses to the map. In the future, when drawing a fairway that surrounds a green (i.e. osm.org/way/1360644967), could you combine the fairway and green together (select both and press 'C' on the keyboard) to create a multipolygon? Thanks!

162621635 6 months ago

Hey there Brad,

Thanks for your work on golf courses. I'm hoping you can do a favor for me that will save me some future work. When you draw a fairway that surrounds a green (and other things like bunkers), could you select those items and combine/merge them together into a multipolygon? The keyboard shortcut is 'C' in iD. Thanks!

162542008 7 months ago

Thanks for listening to my suggestions Steve. It's great to see you creating the multipolygons around the green now. I really appreciate it.

I noticed that you are making golf=fairway polygons around the green that butt up against the rest of the golf=fairway polygon for the hole. They are typically considered to all be the same fairway and should be represented as a single polygon. That's how it's typically mapped from my experience.

162474865 7 months ago

Thanks Steve. There's nothing inherently wrong with fairway going around the green. You just have to make sure the lines don't intersect/touch and that you combine them into a multipolygon. For instance, if you look at osm.org/way/1352433807, you can see it has great imagery and the fairway grass can be seen going all the way around the green. In that case, draw the fairway all the way around, select both (shift click them) and then type 'C' to "Merge" them together into a multipolygon.

162408944 7 months ago

There's a problem with some of your golf course mapping. You've made fairways (for example osm.org/way/1359162412) that intersect other features on the course. In that example, the green. These intersection shouldn't happen. See osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls for examples on how to properly map golf courses. Thanks.

162437623 7 months ago

Hey Brad, there's a problem with some of your golf course mapping. You've made fairways (for example osm.org/way/1359357658) that intersect other features on the course. In that example, the green and and sand trap. This intersection shouldn't happen. See osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls for examples on how to properly map golf courses. Thanks.

162474865 7 months ago

Hey Steve, hate to report this on Valentine's Day of all days, but your deletion of osm.org/way/1034890320 broke the relation that it was a member of. It was happily coupled with the green, but when you deleted the fairway, you left the green single and lonely. I see that you created another green in its place but failed to introduce (merge) it with the existing green.

Please see osm.wiki/Relation:multipolygon to understand the concept and give instructions on how to create them in your editor. You should also check out osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls for some common errors in mapping golf courses.

Thanks.

162505190 7 months ago

No problem. It happens to all of us at one time or another. The tools really need to soft-block any attempt to create something like this.

162505190 7 months ago

Please be careful that you don't make changes that span massive portions of the map.

162436452 7 months ago

Oh, and you might also want to consider learning how to use JOSM if you are going to do a lot of golf courses. It will make life a lot easier than using iD.

162436452 7 months ago

Good Morning J,

There's a problem with Hole 8 (and possibly others that you've created). You have the polygon for the fairway and the polygons for the sand traps/bunkers intersecting. They shouldn't be drawn in such a way and the fairway needs to be adjusted to go around (or beside) the bunkers.

It would also help out if you could combine any fairway that completely surrounds a green and/or other features into a multipolygon. See the wiki for examples: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls

Thanks.

162440060 7 months ago

Why are you deleting this golf course?! There needs to be a better explanation than just "The Diplomat" in your changeset comments. If you need to "improve" the course, you need to keep the existing features whenever possible to preserve history. Thanks.

162371821 7 months ago

Hi Haggardlyforte,

I've gone ahead and reverted this change in osm.org/changeset/162441660 and wanted to let you know why.

The existing features that you added "golf=fairway" to are part of something called "multipolygons". They combine things like fairways and greens together to indicate that everything that isn't a green/bunker/etc is part of the fairway. To go back and label the piece that defines the "outer" boundary of the multipolygon incorrectly as it says that *everything* within that border is a fairway. Hope this helps. Please let me know if you have any questions.

162315343 7 months ago

"This feature has been labeled as deprecated. The recommended replacement is: railway=station mapped as an area."

That's from the Tag:railway=facility wiki. I'd like to see someone replace the facility with a station area to preserve some of the history instead of adding a singular node.