OpenStreetMap logo OpenStreetMap

Changeset When Comment
125253035 6 months ago

Whoa! Cool! Thanks archpdx for doing the work on this.

https://ultra.trailsta.sh/#map&m=17.26/44.0406/-123.0713&q=LQhQGcBcE8BsFMBcoAELYENrwE7mWmsCjAA5IrjQC2ARgPayqFoCWAxvQHbD0BuuTKUQoMsAO5ZwzFh27BW1DAHMkMlimKcx8cO3jqWxYopUGNG4yk5d2GSIYuaUAcnjV6AK1aIAZpmVgF0cLKwATenFbDHBzJ1CUAG0UVUgAGmt6AFcuSBxoFABdEOcTJVUSohR3Lx8ARyzdSFZuUBBgUETaBgAPRABvfu76HoBfUcKAblAucRxEpS4AfSUw+ABefxVSRnhCxM4cvOgp0GzIa3hc3EmgA

163446770 6 months ago

◉ The lines that define Fairways and Greens should never intersect or partially overlap each other. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). If there is no obvious fringe, the fairway should butt up against the green and every node between them should be shared. Please read the wiki for visual examples and instructions on how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls

163424108 6 months ago

Hey there malifica,

I see that you edited one of the fairways incorrectly. If you look at osm.org/way/1247954535, you added the tag of "golf=fairway" to a multipolygon. It's not uncommon to think that is a correct tag, but the multipolygon already defines what inside that boundary is a fairway and what is a green. So it correctly identifies just the fairway as a fairway, but you have come in and said that *everything* inside that boundary, including the green, is to be considered a fairway. Please be careful in the future when modifying objects that are multipolygons. Thanks.

163421269 6 months ago

The lines that define Fairways and Greens should never intersect or partially overlap each other. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). If there is no obvious fringe, the fairway should butt up against the green and every node between them should be shared. Please read the wiki for visual examples and instructions on how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls

163414238 6 months ago

Thanks for adding golf information to the map. I wanted to let you know that you have added what is called a "lollipop" to the course and those aren't supposed to exist. See the wiki at osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls for how to correctly map those situations.

163384888 6 months ago

Thanks for the additions. A couple of comments to improve your mapping if you're interested.
* You shouldn't put names on holes and fairways and greens and such unless the golf course has explicitly named them. You should just use a "ref=1" tag instead of "name=Fairway 1".
* If your fairway surrounds the green, you should select both objects (shift click) and right click to Merge them into what is called a multipolygon.

You can find more information at the golf_course wiki page: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls

163163098 6 months ago

That’s sad to hear. They are 100% wrong. Can you point me to where you heard so that I can prevent this misinformation from spreading any further?

163259458 6 months ago

As mentioned in osm.org/changeset/162300773, you shouldn't be reusing the nodes when the fairways extend all the way around the green. Some sort of fringe should be left or the fairway should come up short and butt up against the green instead of surrounding it.

If you need further clarification, please leave a comment here with any questions and I'll be glad to help out.

163339578 6 months ago

The lines that define Fairways and Greens should never intersect or partially overlap each other. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). If there is no obvious fringe, the fairway should butt up against the green and every node between them should be shared. Please read the wiki for visual examples and instructions on how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls

163226558 6 months ago

Hey there Nat,
Thanks for helping out with my golf cleanup maproulette challenge. One thing to note is that the green and fairway shouldn't share nodes when the fairway fully surrounds the green. There should be a fringe that is left so that there is a gap all the way around the green. Of course, if the fairway doesn't surround the green, but instead butts up against it, then yes, by all means share the nodes between the two objects. Thanks again!

163163098 6 months ago

Overlapping fairways and greens is bad, but so is "almost touching". What you should be doing is *sharing* the nodes between the green and the fairway. Take a look at the wiki (osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls) for examples. See osm.org/way/1361164081 if you want to look at an example.

163137912 6 months ago

Overlapping fairways and greens is bad, but so is "almost touching". What you should be doing is *sharing* the nodes between the green and the fairway. Take a look at the wiki (osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls) for examples. I've gone ahead and fixed osm.org/way/1361164081 if you want to look at that for an example.

163227978 6 months ago

Thanks for helping with my golf course cleanup project!

163132655 6 months ago

Thanks for helping with my golf cleanup project!

163098973 6 months ago

Please don't break existing fairway relations. You need to read the golf_course wiki first before you make any changes that undo the work of others. Thanks.

163068703 6 months ago

Hi Stykman17, thanks for your contributions. In case you weren't aware, fairways that completely enclose objects like fairways and sandtraps should be turned into multipolygons. See osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls

Thanks.

163053806 6 months ago

Hi eschack50, thanks for your contributions. In case you weren't aware, fairways that completely enclose objects like fairways and sandtraps should be turned into multipolygons. See osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls

Thanks.

163052751 6 months ago

Hi RoadHog56, thanks for your contributions. In case you weren't aware, fairways that completely enclose objects like fairways and sandtraps should be turned into multipolygons. See osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls

Thanks.

163051962 6 months ago

Hi Daskey, thanks for your contributions. In case you weren't aware, fairways that completely enclose objects like fairways and sandtraps should be turned into multipolygons. See osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls

Thanks.

163034178 6 months ago

Hi there jemiller,

There are some problems with your golf course mapping and I wanted point them out so that you can correct them and map future golf courses abiding by community standards. A very important wiki to read is osm.wiki/Tag:leisure%3Dgolf_course.

Two of things I noticed off the bat are that your fairways are intersecting and partially overlapping the greens. There are two ways to properly map these. One is to butt the fairway to the green and share the boundary nodes between the two lines. The other is if you can see a fringe around the green that is similar to the fairway, you should completely surround the green with the fairway and then merge them together by selecting them both and right clicking and selecting merge.

The other problem is that you are naming the elements "Hole 18" and such. Those aren't the actual names and your shouldn't use names to describe features. Instead you should use the "ref" tag and set it to "18" and leave the name tag unset.

Please let me know if you have any questions.