RE: osm.org/way/823646710

Hello Ad,

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things.

Thanks!

RE: osm.org/way/1385495878

Hello Rick,
The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

Ha! I also comment on my accidental oversized changesets to prevent people from yelling at me.
:)

Looks like you use that pattern already in other places, so maybe it just slipped your mind on this course. (See: osm.org/way/1385463152)

Thanks for noticing this and fixing it (and correctly, to boot).

For the same reasons that fairways shouldn't intersect greens, roughs shouldn't intersect bunkers. Hopefully I can convince you that going around the outside of the bunker (with a gap), or around the inside (with or without a gap) is the right way to draw these going forward. Here is a before/after:

https://ibb.co/1FsxRxV vs. https://ibb.co/r2QHxcky

thanks.

RE: osm.org/way/1385096281

Please don't use the "lollipop" style of mapping golf course elements as you've done in the URL above. You need to create proper multipolygon relations in order to map features like roughs/bunkers that are within other features like fairways. Please see osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls and osm.wiki/Relation:multipolygon for help in understanding how to map this situation. If those aren't clear, please let me know and I'll help explain them further. Thanks.

RE: osm.org/way/1384653474

Hello Numac,
The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset.* If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things.
Thanks!

* Specifically you have two fairways that intersect each other. If you are adding a fringe to an existing fairway, you need to modify that geometry instead of overlapping them. Your editor might be able to merge the two fairways into a single one, but I'm not sure how to do that in iD.

Hello tizzzod,

As I mentioned a couple weeks ago on a previous changeset of yours (osm.org/changeset/165307330), fairways and greens (and most other golf course elements other than golf=hole) shouldn't intersect. Please refer to the wiki in the previous comments on how to properly map courses.

Hello Patrick

Please don't upload non-existent features to OSM, even if you have plans on deleting them in the future. If this was a golf course in the past and you'd like to have it mapped for historical purposes, you should look into OpenHistoricalMap for your preservation needs. I've gone ahead and reverted your changes.

RE: osm.org/way/1383807749

Please just use regular polygons for defining a fairway and a green. There is no need to break up the polygon into segments and turn it into a multipolygon. You can share the nodes between the fairway and green. Most editors, including JOSM, will "snap" the cursor to existing nodes when you approach them. If you have any questions, please reach out and I'll gladly help.

RE: osm.org/way/1383740199

Hello DBliss,

Please don't map a fairway as to adjoining objects. There doesn't seem to be any clear reason why that shouldn't be a single object that surrounds the green. You should be able to select both of them and "Merge" it and your editor will do the right thing. Please reach out if you need help.

Thanks.

RE: osm.org/way/791902954

The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

Hello Chris,

What's up with the shape of the fairway on Hole 2 near the green? I'm not sure what you're trying to do, but it looks like no other golf course hole and I'm concerned there is a mistake in there somewhere. But I'm not sure your intent, so I wanted to check first.

Hello Badrinadh,

Why are you mapping both sides of walls in osm.org/way/1349033276 (for example). Wouldn't it be much cleaner to just map the wall as a single line.

I think there is something very wrong with osm.org/way/1223105432 but I'm not sure how to fix it. Sounds like you might be more local and can make the appropriate fix. Thanks.

Why are you adding the neighborhood border when it already exists (osm.org/way/646100522)? Please remove it so there are duplicates. Thanks.

I've reverted this change as it messed up a bunch of lines around the church property. My guess is that multiple things were selected while you moved a point thinking that you were only moving a single object. Feel free to attempt fixing up the parking lot, but make sure you review your change fully before uploading. Thanks.

I never know exactly how to mark a business as no longer what it is, but I am aware that disused as a "lifecycle" tag is used. I would have to read up on if it should be "disused=golf_course" or "disused:leisure=golf_course" and remove the "leisure=golf_course" tag. But you'd have to double check the docs to be sure.

Thanks bp. We appreciate the help.