OpenStreetMap logo OpenStreetMap

Changeset When Comment
159249689 9 months ago

Alrighty, since you ask for a review I thought I'd do that for you. Thank you for adding the missing path. The more you look the more you'll find places to add to the map.

There are other aerials you can use to better align the walking path to them. You can find them in the background section in the Id editor. For tree covered areas I usually look at the Orthoimagery from 2020 first.

The name field can be blank and actually should be blank unless it has a sign for the name. If you know that it lacks a name, you can manually add a tag noname=yes

159060203 10 months ago

I reviewed it for you. That outline is for the building not the property lines. I have fixed it for you and added a parking lot for you.

158563674 10 months ago

Please reread the changeset comment. I fixed some of the landuse issues, but not all of them.

157649284 11 months ago

If it's on public land and my checking of public plots indicates it is, it shouldn't be private. It'll confuse mappers in the future.

Now, if the gate is locked, set the gate to locked .

Change the track surface and smoothness to like ATV so routers won't route through it.

It's slightly more correct. This gives people all the information they need to know about it.

157558728 11 months ago

Just FYI, when you're adding generic POIs, like parking, dumpsters, picnic tables, fire hydrants, etc. Please omit the name tag. See the wiki for more information for when to use it.

osm.wiki/Key:name

I have removed the name tag on a few of them for that reason.

157060093 11 months ago

Just a heads up. It's not considered a good practice to attach landuse to roads. The roads should be consider the centerline and not the edge.

If you see it elsewhere on the map (and you will) it's a minor mistake.

It seems like a small things but it makes the map more accurate and maintenance easier.

You can attach landuse to other landuse if it's not separated by a road/river.

157150239 11 months ago

Hello, you requested a review. First thank you for contributing. OSM seems extremely intimidating at first, but reality is very few people are contributing in the US so each of our contributions are impactful.

Alright review time.

Be careful not to attach buildings to roads. The only time this is acceptable is when there are roofs for like gas stations and drive-throughs. If you accidentally attach something, hit the d key to detach it. You can also hit the undo button or ctrl-z.

Be sure to hit the Q key on rectangular buildings to give them pretty right angle corners.

I also recommend zooming in a bit more when drawing, it makes it easier to position buildings correctly.

In Id (the web editor you're using), you can search for the most common businesses brands (Giant, Michaels, Starbucks, McDonalds, etc) when choosing an area type and it'll fill out more information for you.

I have already cleaned up the buildings for you.

Please keep contributing, even just leaving notes that a certain business is open or closed is really helpful to people who are mapping states or countries away.

157045937 11 months ago

Township let me know I have to submit it to state. I have also done this and have requested a response.

157045937 11 months ago

The Mount Olive Township request to have the sign added is #745338289.

157045937 11 months ago

I spent 15 minutes checking double line laws and referred to somebody who drives by that gas station daily for work.

The best I can tell is Title 39. Section 39:4-123 covers it. It is legal to cross double yellow lines to enter businesses and residences as per page 75 the NJ driver's manual under "Left turns, between intersections."

https://www.nj.gov/mvc/pdf/license/drivermanual.pdf

The person who drives by it daily says the turn is taken but very rarely utilized cause of traffic.

I spend a lot of time mapping this area, unless there is a R3-2 sign saying no left turns, I leave it. This is to respect the local businesses.

I recommend contacting your SW team to start respecting the "destination" access value.

All that said, I will contact my local township and inquire about having a R3-2 sign added to the location.

157045937 11 months ago

I reverted this changeset because this doesn't allow customers to make a turn into the gas station. I understand routers are incorrectly routing through the gas station. A better solution is to set the access of the service road to destination, which I will also make for you.

osm.org/changeset/157063842

156689449 11 months ago

If you look at the nearby "Ye Old Mill Shoppe" you can see where it was used. I'll probably be deleting the Mill soon cause it's not present on our newest aerials.

If you do make a mistake on deleting, you can always revert the changeset using https://revert.monicz.dev/ which will readd it with the original IDs. You can revert other people's changes too, but be very careful when doing.

But I expect we'll be mapping a road through it soon anyways.

156689377 11 months ago

Well I'm the person who broke the continuity, and in retrospect it was a small mistake for me to do that. Just to warn you, because of the ambiguity the road classification system it is fairly contentious. It's weighs lane counts, what it links, speed and how much traffic is on it. And different people have different weights on each.

For instance, there's a road, "Irish Spring Road" over in Roxbury has been classified as almost everything in it's history.

One of my rule of thumbs was anything with a 30 mph and over speed limit would be tertiary at least.

Regarding source:ref, OSM has a ton of mildly esoteric tags (and they keep making new ones) that ID doesn't show you. I don't blame people for not knowing them. But at OSM scale the more common ones are useful to learn.

156689377 11 months ago

Instead of putting the source into a note. Add a source:ref tag and add the website there.

Various source tags lets others know where you got the information and help avoid unnecessary arguments/edit wars.

For more information:
osm.wiki/Key:source

I'm speed running you through the tags cause it prevents you from repeating minor mistakes.

While on the topic, if you redo the geometry of an imported building (source=Morris County GIS), please delete that source tag as you're now the new source.

156689377 11 months ago

I have found classifying roads into primary/second/tertiary in the area extremely difficult. Due to the hills roads take a lot of non direct routes.

The classification mainly changes what zoom level they render at and gives an idea of how useful they are to know.

As a rule of thumb, I was going off speed limits which is why I initially downgraded it. But you're right it probably should be a secondary cause it looks weird to have a tertiary in-between two secondaries and despite it's speed it's heavily used.

156689449 11 months ago

There is a tag called a lifecycle tag.

osm.wiki/Lifecycle_prefix

We usually add these tags buildings that are demolished but still appear in the latest aerials. Then after the aerials are updated (or possibly the construction is finished), we delete it.

The tag will removes it from the rendered map, but it keeps it in the editor. It mainly prevents people from accidentally readding the buildings from aerials.

...but since I'm the only person who would likely be readding it, don't worry about it this time. I'll add a construction area around it next time I drive down it to remind me and others.

156448128 12 months ago

Hi, thanks for updating OSM.

I reworked the building and your business a bit to make it more consistent with the rest of OSM and the less frequently used tags. Please check it in about a day as map rendering can lag a bit.

147302768 12 months ago

I was impressed by the quality of your work. Keep it up.

156151415 12 months ago

Oops, I think I had conflict that created those. I hate it when that happens.

155947930 12 months ago

Nice job on that baseball field. I wish more mappers had your precision.