OpenStreetMap logo OpenStreetMap

Changeset When Comment
81984199 over 5 years ago

What's going on with the service road you modified here? Clearly this isn't what you intended, but is there something you were trying to do?

74196974 over 5 years ago

Good catch, that should be the Gino's pizza at https://ginospizza.ca/ (which, ironically enough, is a larger franchise, but no Wikipedia or Wikidata). I'll try to remember to fix it tomorrow, or you can fix it before, whichever.

80119778 over 5 years ago

Thanks for the edit. :)
For future reference, these should just be tagged as building=house. Residential areas would cover basically the entire block (it's roughly akin to zoning). Side tip, if you press "q" with a building selected, it will turn the corners into right angles, which can make things look a little cleaner. I went ahead and did that for these.

79662450 over 5 years ago

Just as a heads-up, this changeset added some weird bugs to paths on the UW campus (now fixed). Not sure what exactly went wrong, but if you do, just keep an eye out in the future. One way to do that is to look at the warnings iD generates, you'll get a yellow warning on the right under "issues" if you introduce problems like these.

77410781 over 5 years ago

Some of these are very obviously not real. I'm going to revert all your edits. If this was a mistake, please let me know, otherwise I'll have to report for vandalism.

77442030 over 5 years ago

Are you sure these actually exist? There's no sign of them on aerial imagery.

77410876 over 5 years ago

This embassy clearly does not exist. What was it you were trying to do here?

76774151 almost 6 years ago

for future reference: paths should terminate with an intersection node with the way they connect to, not where they physically end

76666327 almost 6 years ago

Oh no worries, none of us ever stop making mistakes, was just a tip. The thing I thought JOSM would have caught was the lack of intersection nodes on the pedestrian crossings with the road, but maybe it missed it. The reason I recommended the "Update modified" is your change mixed weirdly with a set of minor alignment tweaks I'd made a little earlier, which ended up as lone nodes (simple to fix though).

The bigger issue with this edit was that you accidentally tagged nearly the whole spur line trail as a pedestrian crossing, but JOSM won't detect that (in fact JOSM likely caused it, since it has a habit of assuming any time you're making a new way, it's an extension of an existing way if possible). Things like that happen, which is why I try to review edits in the area, including my own. :)

76666327 almost 6 years ago

Make sure you take a look at the warnings the editor generates, and to use the "Update modified" feature in JOSM before uploading

75962525 almost 6 years ago

You may find it obvious, but routing software does not. A simple test with OSRM confirms.

75804539 almost 6 years ago

I don't see a centerline tag documented anywhere, and there's only 90 uses worldwide. Are you intentionally trying to create a new tag, or was this a typo of some kind?

75020059 almost 6 years ago

Ah, got it. Just watch where you swing that hammer ;) Don't want to discourage newbies, even if they make mistakes

75049427 almost 6 years ago

Is construction complete here? If so, the construction area should be removed. Also, since you're using iD, note that you can switch imagery by going to the "Background settings" tab on the right (Maxar in particular seems to have these buildings).

75020059 almost 6 years ago

Can you explain in more detail why you reverted this entire edit?

74833193 almost 6 years ago

I removed those two nodes, since they're already tagged. When mapping something that can be an area or a node, you can do one or the other, but not both. So in this case, the parking lot and building already had those tags on the areas, so you don't want to put nodes with the same tags there, or it will show up twice.

74832970 almost 6 years ago

I've removed the bike paths you added. For one, they were already tagged on King Street via the "cycleway" tag. You can map them as separate ways if you'd like, but if you do, remove the cycleway tag from King on the corresponding stretches, and make sure that the new way has intersection nodes on all cross streets, crosswalks, and railways.

67775589 over 6 years ago

This change seems to have created a bunch of tagless nodes. E.g., osm.org/node/6316661508/ and osm.org/node/6316661553/ (though there appear to be hundreds). Could you try this change again?

62871833 almost 7 years ago

The lines you turned to sidewalks aren't sidewalks, they're address interpolations provided by StatCan (i.e., the government) osm.wiki/Addresses#Using_interpolation

Some of those roads do have sidewalks, but they're not the same as the address lines. In general, the sidewalks and address lines shouldn't match up (for one, sidewalks almost always have to intersect with streets, while addresses almost never will, but more generally they just aren't the same shape/location).

Also, some of the address lines you tagged as sidewalks don't have sidewalks on those roads. If you don't know whether a road has a sidewalk or not, it's best to leave it as is (or do a survey! :) ).

52876167 almost 8 years ago

ugh did this just break another larger changeset? Feel free to undo this if it's easier, I can figure it out some other time.