Bien vu, il faut repeter année et mois, 2022 Mar 07-08,10-11 devrait etre 2022 Mar 07-08,2022 Mar 10-11

Je corrige kopeninghours, ainsi que ce noeud.

OK, thanks for the feedback. Done and documented in osm.wiki/Import/FrenchPostOfficeOpeningHours#Data_Import_Workflow

OK, thanks for the feedback. Done and documented in osm.wiki/Import/FrenchPostOfficeOpeningHours#Data_Import_Workflow

Right, that's a possible further simplification. I'm reviewing tons and tons of entries to make the data valid, not necessarily as short as possible (the software I wrote for this, doesn't do that).
I'll change this one now that you pointed me to it :-)

Hi,

The evaluation_tool has some builtin tolerance. The actual spec has no support for "Dec 24,31", it's "Dec 24, Dec 31".

See monthday_selector (where the comma is), monthday_range, and date_from in osm.wiki/Key:opening_hours/specification#daynum

Imagine the initial value didn't have the ":" after Mo-Fr. It would still have been wrong (because in fact it's only open in summer) and it would still not have been in any QA tool.

We can't just leave every minor syntax error out there, just in case there's an unrelated semantic problem in the value.

It's like saying, let's not fix typos in blogs, just in case there's also a major misunderstanding in that blog :)

In general I completely agree with the idea of not silently hiding actual issues, and I'm careful about that. But I don't believe this is what happened here, it was just coincidence that the entry had "Mo-Fr:" and, also, a ';' instead of ',' to bundle both parts into the Jul-Sep month range.

Yes the ":" after weekday names isn't in the spec (osm.wiki/Key:opening_hours - see "weekdays") so there's no guarantee that all implementations will understand that syntax.

Thanks for finding out about the correct value and fixing the attribute, much appreciated.

OK, thanks. I see your point.

But of course even entries with a valid syntax can be wrong when the person entering those misunderstands the spec (as would be the case here without the ":" after Mo-Fr, which is unrelated to the question of whether Jul-Sep was supposed to apply to everything or not).

I don't see why I should refrain from touching entries like this one, the removal of ":" after Mo-Fr is completely unrelated to the question of whether the person understood the month-range part of the spec when writing the entry.

Are you sure that it's wrong?

It was
Jul-Sep: Sa, Su 10:00-12:30; Mo-Fr: 10:00-16:30

and I removed the ":" after Mo-Fr.

This is saying "open weekends in summer, and open week days all year". This seems pretty valid to me, doesn't it?

Can you explain to me what is still wrong even after correction here?

I did not modify any address, only the opening_hours attribute.

Both are valid and in this case equivalent because the days are different. You can test it on https://openingh.openstreetmap.de/evaluation_tool/

Osmose se trompe, ces horaires sont corrects. C'est un bug Osmose, https://github.com/osm-fr/osmose-backend/issues/555
Je suis sur le point de réécrire une nouvelle lib python pour remplacer le mauvais parseur utilisé par Osmose...