OpenStreetMap logo OpenStreetMap

Changeset When Comment
127710577 almost 3 years ago

I reverted your changeset in osm.org/changeset/127715939 because the Ukrainian OSM community urges us not to edit the map of Ukraine during the war there (see osm.wiki/Russian–Ukrainian_war).

127713077 almost 3 years ago

Thank you for your cooperation. The Ukrainian OSM community will be happy if you stop mapping in their country until the war is over.

127691122 almost 3 years ago

I reverted your changeset in osm.org/changeset/127713077 because the Ukrainian OSM community urges us not to edit the map of Ukraine during the war there (see osm.wiki/Russian–Ukrainian_war).

127545938 almost 3 years ago

That was an accident. I was making tiny changesets in rapid succession.

127438458 almost 3 years ago

that's a misclick. I've fixed it in osm.org/changeset/127566410. Thank you for bringing it up.

113979184 almost 3 years ago

Ja, maar building=ship is ook niet de mooiste tag, het rendert alleen leuk en het is ook vastgoed.
Er staat nu building=shelter op en dat werkt naar mijn idee goed genoeg.

37757548 almost 3 years ago

You're very welcome :)

JOSM gave me nearly 13,000 warnings yesterday AFTER the cleanup that included 80,000 object deletions and some regular QA. The number of Osmose issues to my name has also skyrocketed. All in all this area is an gargantuan mess.

Is this a low quality import or did the mapper actually map this manually while ignoring the validators?

127272826 almost 3 years ago

Thank you for your effort and sorry for my rude remark earlier. This looks like an improvement, but does it have to be one giant multipolygon?

113979184 almost 3 years ago

Een dak met ondersteuning is amper een gebouw te noemen. In andere gevallen zoals bij bushokjes of overdekte fietsenstallingen taggen we de daken doorgaans ook niet als gebouwen. building=roof vind ik maar een vreemde tag.

37757548 almost 3 years ago

I simplified most objects in this area with a 0.1 meter error margin:

osm.org/changeset/127414795
osm.org/changeset/127414809
osm.org/changeset/127414818
osm.org/changeset/127414822
osm.org/changeset/127414876

osm.org/changeset/127417184
osm.org/changeset/127417253

In total I removed about 60,000 objects, most of which were nodes.

There are still a bunch of unwanted intersections of barriers, waterways and other objects in this area.

113979184 almost 3 years ago

Teruggedraaid in osm.org/changeset/127409725

De naam was ook maar een omschrijving, dus die heb ik ook verwijderd.

Omdat de muziektent geen deuren of muren heeft, valt nog over na te denken om de building tag te verwijderen en alleen amenity=shelter + shelter_type=weather_shelter te gebruiken, of om anders dit allemaal weg te laten en in plaats daarvan covered=yes te taggen.

Dit klinkt voor mij als iets om een bredere discussie over te voeren.

126348760 almost 3 years ago

Hi Wilmer,

I removed your enormous landuse in osm.org/changeset/127272826 because it included so many areas that were definitely not residential landuse. This was just lazy work on your part, really.

127147913 almost 3 years ago

"onwenselijk" is een persoonlijke, subjectieve mening. Objectiever gezien zijn deze paden vrij begaanbaar, dus dat is hoe ze op de kaart horen te staan; zonder access tags (of met access=yes).

127050392 almost 3 years ago

You're welcome! Have fun making your map of the rivers :)

126925539 almost 3 years ago

"what you actually do is removing tags and adding the values with a different key."

This is true.

"you may be responsible for breaking them, by performing huge edits which might force the devs of other software to add code in order to maintain the status quo"

It's called the evolution of OSM's tagging schemes, and look at it from the other side: there is no point in retagging all 85,000+ wikimedia_commons=* tags back to image=*.

"hm, not quite desirable IMHO to have a key for every service that can be used to share pictures. I can understand we could make a case for wikimedia, as they are so huge and terms are open, but it is not an approach that scales well for _every_ image hoster"

I couldn't agree more with this statement.

"while you should try to respect the guidelines,"

If the guidelines say that I should spend a good week discussing a few hundred image tags that I actually verify in my edits with every relevant national, sub-national community and local mapper who might not even be in any community, I think I'll pass.

"I think this particular edit has its merit, the "file:"-URLs in the image tag, where everybody expects an http-link, had their problems. Thank you for performing it and discussing about it."

You're very welcome. I'm glad we could have a constructive discussion about this.

126925539 almost 3 years ago

"you are removing tags"

No, I retag it to the key that we have for Wikimedia Commons images. I thought I mentioned this already.

"break other people’s apps"

I'm not responsible for other people's apps, only for the map data in my edits. I haven't removed any data, and if you find any app that doesn't support the wikimedia_commons=* tagging scheme, your attention is better spent on convincing them to use it, because there are over 85,000 of them on OSM.

"I added a check for the wikimedia_commons tag as well, and it could be seen as “better” to make an exception for commons"

Yeah, that sounds like my reasoning behind this edit. I simply updated the map data here to match this.

"next comes imgur, flickr, panoramio whatever as keys?"

Well, we already have Mapillary, but I doubt the others will follow anytime soon because of licensing reasons.

"Not sure where the url escaping came from, maybe GoMap!! does it automatically?"

No clue, maybe people just copy things directly from the URLs, but fixing it isn't too difficult in most cases.

I tried and failed to make a MapRoulette challenge for it, maybe I'll try that again so we have a more efficient QA pipeline to verify image tags.

126925539 almost 3 years ago

I hope that answers your concerns and questions well enough :)

126925539 almost 3 years ago

"you are removing tags"

Not at all, I'm just retagging them under the key that's specifically intended for Wikimedia Commons images. No information is lost.

"now I do not find them anymore"

Not in the image=* key, no, but you will find them under wikimedia_commons=* together with the other Wikimedia Commons images.

"you not only added the wikimedia_commons tag, you also removed the "image" tag"

Indeed I did. I see no merit in tagging the same thing twice, because that is inefficient and may lead to redundant duplications.

Other than that, software that only looks for full weblinks in image=* and "File:..." in wikimedia_commons=* key will now miss much less relevant data.
The osm.org website is a good example of this: "image=File:..." will not be hyperlinked on this website, but "wikimedia_commons=File:..." will.

"did you have a look at the pictures? Have you seen a fountain picture or two?"

Surely I did. They look good. I always include quality assurance. That is also how in other changesets I discovered and fixed poorly formatted tags like "File:Fontana%20Piazza%20Brin.jpeg" instead of "File:Fontana Piazza Brin.jpeg" (fictional example).
I also discovered and fixed a few cases like this: osm.org/changeset/126957131

126925539 almost 3 years ago

This isn't very automated. I checked all the tags to verify if they indeed refer to Wikimedia Commons.

120705288 almost 3 years ago

Done in osm.org/changeset/126957131 . Thank you for being so understanding, and have a good day :)