SafwatHalaby's Comments
Changeset | When | Comment |
---|---|---|
51350214 | almost 8 years ago | Thanks! I also think this should be adopted globally, but I still need to polish/simplify the code a bit first. The bot makes assumptions that are agreed upon only in Israel and there's special treatment for some tags like name/operator. Making it global requires a bit more work. Most people don't add the Wikidata tag, so right now the bot tracks many tags like brand/name/operator to track POIs. I could make it track using the wikidata tag if it's present and fall back to other tags otherwise. |
52099837 | almost 8 years ago | Hi and welcome to Openstreetmap. I think your Dom of Rock edits are invalid. This place has 3 structures.
You renamed "Holy of Holies" to "قبة الصخرة" and now the map has two domes of the rock. You also removed the "jewish" tag from the two structures. Would you mind if I fix this? |
51469993 | almost 8 years ago | Reverted in osm.org/changeset/52098819 due to lack of explanation |
51431708 | almost 8 years ago | ...and osm.org/changeset/51992698 |
52058718 | almost 8 years ago | Thank you for the Arabic name translations in Israel! I was wondering if "ref:ar" has any practical use at all for road numbers. Clients can trivially convert between Arabic and regular numerals, so it seems unnecessary to me. |
51350214 | almost 8 years ago | " I believe that I have made a mistake with that edit - they should have been tagged as brands, not operators." - Note that this actually depends on the regional conventions (if they exist at all). In Israel, chains have the same "brand" but this is not necessarily true everywhere. And prior to Swiftfast_Bot there was no consistency at all. (some people used the operator tag and some used brand). |
51350214 | almost 8 years ago | Specifically for israel: There's no need for an ID table or manually reversing your edits. Swiftfast_Bot maintains those chains, and all you have to do is edit the following templates. Here are the templates: osm.wiki/User:SwiftFast/scripts/brand/templates So you'd need to add:
and remove "wikipedia", "wikidata". The bot will then fix all chains. (And I can easily tell it to remove wikipedia/operator:wikipedia/ etc). |
52035842 | almost 8 years ago | Please note the conventions for Israeli roads: osm.wiki/WikiProject_Israel#Inter-city_Roads (I have not checked if this breaks any conventions. Just thought I'd point this out). |
51350214 | almost 8 years ago | I apologize, the forum thread relevant for brand vs operator is actually https://forum.openstreetmap.org/viewtopic.php?id=57986 |
51350214 | almost 8 years ago | Hello, thank you for taking your time and editing the map. I have some questions. Wiki states: "You *may* tag secondary attributes of the feature by preceding the wikipedia key with the name of the attribute". This is clearly optional, and I chose to avoid it for simplicity because the individual shops are extremely unlikely have their own wiki pages, and because the plain form is likely more widely supported. 2. Was this mechanical edit discussed anywhere prior to the edit, as required in the automated edits code of conduct[1]? Firstly, these nodes have no "operator" tags as agreed upon in the IL forums[3], but the edit adds an "operator:wd/wp". It would have been more accurate to add a "brand:wd/wp". Also, these tags are mechanically maintained by SwiftFast_bot[2], which is now throwing warnings. Prior discussion would have been nice. lastly, the link in the description seems broken. There's no section for quality control. Thank you for your time. [1] osm.wiki/Automated_Edits_code_of_conduct
|
51974105 | almost 8 years ago | هذه خارطة عامة. الرجاء اضافة اماكن ذات اهمية عامة فقط وعدم اضافة اماكن شخصية مثل منازل على الخارطة. بامكانك اضافة اماكن شخصية في هاتفك بدون تعديل للخارطة العامة عن طريق استعمال ميزة ال"إشارات المرجعية" في التطبيق. شكرا Please avoid adding personal places to the map. OpenStreetMap is a public map. If you want to save personal things, use the Maps.Me bookmark feature. Map edits should contain public points of interest only. Bad edits were reverted. |
51621119 | almost 8 years ago | Hello and welcome to OSM. You removed a parking lot. Is the parking lot gone or is this a mistake? |
51603770 | almost 8 years ago | Welcome to openstreetmap :) I changed the road type from "residential" to "service". I removed the road names and put the name on the parking lot itself. Happy mapping! |
50755701 | almost 8 years ago | שלום! ניתן לשוחח עם הקהילה הישראלית כאן: |
51501290 | almost 8 years ago | You can add a description="Sometimes closed". |
51501211 | almost 8 years ago | It is easier to mark as highway=footway. יותר קל לסמן שביל כזה באמצעות highway=foot
|
51489849 | almost 8 years ago | It looks like a shift-edit. Perhaps your imagery was mis-aligned? |
51469993 | almost 8 years ago | That's a massive deletion. Any explanation? |
51452510 | almost 8 years ago | You can simply use highway=footway instead of the multiple access tags. |
51431708 | almost 8 years ago | Fixed in: |