OpenStreetMap logo OpenStreetMap

Changeset When Comment
145072393 over 1 year ago

Hi, thanks for your contribution! Since you requested a review, here are a few tips:

- It's best to avoid abbreviations in OSM wherever possible. ("N" -> "North")
- The Description tag should be a concise description of the feature rather than a free-form ad space.
- Opening hours tag follows a specific syntax. It can be a little tricky but using this format makes it machine-readable, meaning apps and whatnot can parse it reliably.

I went ahead and made those changes. Thanks again, and welcome to OSM!

145080973 over 1 year ago

Looks great! Thanks for your contribution.

145085156 over 1 year ago

Looks great! Thanks for your contributions.

144872894 over 1 year ago

I just edited the area and building to try that suggestion out. Let me know your thoughts on this! I get that people are going to clash on some ideas so the last thing I want is silent edit-wars. If you feel strongly about having them a certain way I'm willing to just quit worrying about it and let you do your thing. :) Thanks for your contributions, regardless!

144872894 over 1 year ago

When it comes to tagging the outer area, I think I am still in favor of avoiding duplication by minimizing tags on the building. Perhaps a good compromise would be as follows:

For churches with a single building, meaning the vast majority, put all tags on the building way itself, except for landuse=religious on the outer "grounds" area.

For churches with multiple buildings, put all tags including amenity=place_of_worship on the outer area, leaving only building=church on the buildings.

This tracks pretty closely with the recommended method on the wiki: osm.wiki/Tag:landuse%3Dreligious#Usage

144872894 over 1 year ago

Re: cross vs worship icon, OSM Carto currently correctly uses the latter for denomination=mormon. But they have not updated it yet to correctly handle latter_day_saints or latter-day_saints since the church changed their mind on the mormon name. I looked at some github issues here and there earlier today and it sounds like they want to avoid implementing stuff for which the community has not settled on a common schema for. (Seems like someone needs to take ownership of this issue and do a global tag change, and spearhead the necessary renderer changes.)

128100138 over 1 year ago

That makes a lot of sense. Thanks for the info! (I have this vague feeling I already asked you about this or something similar... Sorry if that's the case.)

144872894 over 1 year ago

Just a heads-up that when both building and outer church boundary is marked as amenity=place_of_worship, it's generally interpreted as two churches. (Two icons and labels rendered, two entries show up on searches, etc.)

For that reason, I've generally tried to put all tags on the outer area, then tag the building as building=church only.
I'm open to other strategies if you disagree with that. Let me know what you think.

128100138 over 1 year ago

Might I ask, what is your source on these changes? I might be wrong, but I think the USFS motor vehicle map shows many or all of these as public roads.

144135792 over 1 year ago

Thanks. My mistake

143951917 over 1 year ago

Hmm, at first I disagreed with your changes here, but after reading the wiki page I guess place=village is technically correct since AFAIK Lewiston and Franklin do have "few facilities available".

143761490 over 1 year ago

Gotcha. That makes sense!

143761490 over 1 year ago

I'm not too familiar with transmission line tagging, is "voltage=138000;138000" correct? For two separate lines or something? osm.org/way/45783089

143628306 over 1 year ago

What's your source on removal of these streams? Are you deleting features that don't appear on the old USGS topo maps?

143659354 over 1 year ago

Argh. I can't get these right. This was meant to be uploaded using my import account, Xvtn_Import.

143375684 almost 2 years ago

Thanks!! Hours can be so tedious to add and are arguably some of the more useful POI data in OSM.

143374124 almost 2 years ago

Hi, and welcome (back) to OSM! Thanks for your contribution. Street names can be tedious to collect so this is valuable info. One very minor tip - it's best to avoid abbreviations in OSM. The reason for this is that it's easy for software to shorten words, but sometimes it's much harder to expand them. Here's some more info: osm.wiki/Abbreviations

Anyway, thanks again for your improvement, and I hope you feel you can work on our valley's data anytime!

143252053 almost 2 years ago

I'm all for adding trails based on Strava data, but I disagree with deleting them without checking on-site. The trail might just be less-used or not used by the Strava-type crowd. Any thoughts? Were you able to check that City Creek trail in person?

142120380 almost 2 years ago

Thanks for doing this. Since they changed the recommended tags, I've wondered - Aren't crossing=unmarked and crossing:markings=no redundant? Anyway, I hope at some point the iD presets get updated to include this. Thanks again!

142037399 almost 2 years ago

Hi, and welcome to OpenStreetMap and the valley. Thanks for your contributions!