OpenStreetMap logo OpenStreetMap

Changeset When Comment
116971729 over 3 years ago

I see now that you didn't just delete the turn restriction, you just deleted the old one and made a new one with the restriction "only_straight_on".

First of all, please don't delete and remap when possible. Try to preserve history. But also, I would say that only left turn is correct here, since traffic is turning left.

Continuing with revert.
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/116971729

116971729 over 3 years ago

Hi,

First of all, it was fine as it was. Adding curves where there isn't any just to satisfy your QA tool isn't in the best interest of the map.

Second, why did you delete the turn restriction? Now, routing will allow U-Turns at this intersection.

Reverting.
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/116971729

117254521 over 3 years ago

Actually, now I see that those letters in the trail names actually refer to the color of the trail blazes. This is not the right place to put them, however.
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117254521

117254521 over 3 years ago

Good edit, but the changeset comment doesn't match what you changed.
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117254521

117259046 over 3 years ago

This is an interesting park. It seems like each of these trails have both a name and an assigned letter. I think that putting the assigned letter as a ref might be ideal here, I might come through and change it to this. For example, this trail would be tagged like: `name=Woodlands Trail` `ref=Y`.
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117259046

117258994 over 3 years ago

Hi,

Thanks for trying to fix this, but by having the bridge connected to the stream with a node, you're basically saying that they're connected to each other at the same level. Please try not to do this.
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117258994

117257600 over 3 years ago

I'm not sure that these are good reasons to outright remove a trail. If it's at all possible to walk on, I'd leave it on the map but discourage its use with other tags.
---

Published using OSMCha: https://osmcha.org/changesets/117257600

117895636 over 3 years ago

Hi,

Where did you get the address information from? Is "Crossroads Plaza" a real street?
---

Published using OSMCha: https://osmcha.org/changesets/117895636

117827885 over 3 years ago

Great job! If you could split up your changesets slightly, it would be easier to review. Maybe do the yard in one changeset and the line in the other? Either way, not a big deal, changeset looks good to me.
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117827885

117543294 over 3 years ago

By the way, I only reviewed bad because there was that significant issue with the school. I still appreciate the contribution.

117543294 over 3 years ago

Hi,

Since you requested review, here it is. You did well on mapping the house; I appreciate you moving the tags from the node to the new building. However, other imagery sources are much better here, so you could have mapped more accurately if you used those. Make sure to review your imagery options for each area you work on.

However, mapping the school as a building where the way goes around the perimeter of the premises is not quite correct. You're saying that there's building even in the open spaces on the inside. If you can't fit one way all the way around the building pieces, you can use a multipolygon. See this page: osm.wiki/Relation:multipolygon
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117543294

117449849 over 3 years ago

Hi,

How do you know what the surface is here? I doubt you visited in person based on the changeset type. Also, you have to add a layer tag when making bridges.
---

Published using OSMCha: https://osmcha.org/changesets/117449849

117696154 over 3 years ago

Hi,

Please check multiple imagery sources available to you when mapping. The one you were using probably wasn't very useful here, so you had to put in a rough shape. Other imagery sources here are much better, so you could have mapped the building more accurately to what's on the ground. Either way though, thanks for contributing!
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/117696154

117384951 over 3 years ago

What exactly was this customer feedback? Was streetside imagery used? Has someone confirmed this on the ground?
---

Published using OSMCha: https://osmcha.org/changesets/117384951

117786685 over 3 years ago

Also, please use more descriptive changeset comments than "fix place".
---

Published using OSMCha: https://osmcha.org/changesets/117786685

117786685 over 3 years ago

Hi,

Looks like you're just slightly moving things around here. Different imagery sources are slightly offset from each other, so whoever mapped these features likely was just using a different source than you. In New York State, the "NYSDOP Orthoimagery - Latest" source is most consistent, and I would appreciate it if you used it. It saves everyone work if we don't keep moving things around by a few feet or inches.
---

Published using OSMCha: https://osmcha.org/changesets/117786685

118037482 over 3 years ago

It looks like you drew a road over another road. Please don't do this; modify the existing road instead if necessary.

You can try to fix this yourself, but if I don't hear back for a while, I'll just do it myself.
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/118037482

118037537 over 3 years ago

No need to add this point, the graveyard is already mapped as an area.
---
#REVIEWED_BAD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/118037537

118037581 over 3 years ago

Hi, good changeset, but you could copy the tags from that address node onto the building, to which you can also add the restaurant tags.
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/118037581

109542699 over 3 years ago

Good changeset, just a few things I want to point out:

- If you map a building and there's already an address node on it, you can copy the tags from the old node to the new building, and delete the node. This is preferred for simple buildings like houses.
- The cemetery probably shouldn't be connected to the house building there.
---
#REVIEWED_GOOD #OSMCHA
Published using OSMCha: https://osmcha.org/changesets/109542699