OpenStreetMap logo OpenStreetMap

Changeset When Comment
115178612 over 3 years ago

Hi -

There are MAJOR problems with this import you've done of protected areas in Michigan! We're currently in the process of untangling all the damage here. First off, do not apply land cover tagging (such as landuse=forest) to protected area boundaries. Land cover needs to be mapped separately. Secondly, do not delete accurately-mapped land cover polygons. Thirdly, there are significant structural issues with the polygons associated with this import, with over 2,000 JOSM validator findings on Michigan protected areas.

Fourthly - imports like this need to be discussed (see osm.wiki/Import/Guidelines) so that these kind of problems can be avoided in the future.

Please cease all importing activities until it's discussed as required. Discussion on this topic is happening on the channel #local-michigan on Slack (slack.openstreetmap.us) or can be discussed on the talk-us or talk-us-imports mailing list.

114983290 over 3 years ago

Hi, can you explain this edit? It does not appear to be consistent with the current NY state highway classification guidelines.

115173733 over 3 years ago

Hi - thanks for adding in that river area! I noted that you used waterway=riverbank (the riverbank preset in JOSM) rather than natural=water+water=river (the water->river preset in JOSM). The riverbank tag isn't really used any more (https://taginfo.openstreetmap.org/tags/waterway=riverbank#map). The iD (in-browser) edtor even prompts users to upgrade the tagging automatically.

Also, I encourage you to join us in chat on Slack, at slack.openstreetmap.us, channels #local-maine and #local-us-northeast

Happy Mapping!

115137752 over 3 years ago

Thanks for tagging expressway on these roads! That will be very helpful for the American map style that we're building.

115066768 over 3 years ago

Hey there - thanks for improving the map in Charleston! Just one note that river areas should be tagged natural=water + water=river. This can be found under the water->river preset in JOSM. The riverbank tag is old and isn't used in the US anymore.

Also, come join us on Slack! That's where the most US mappers hang out and chat. You can get online at https://slack.openstreetmap.us/

-ZeLonewolf (Brian)

115037598 over 3 years ago

Hi, it would be helpful if you could put more meaningful comments in your changesets.

See: osm.wiki/Good_changeset_comments

115012078 over 3 years ago

In OpenStreetMap, we map what is actually on the ground, not what people wish to have or not have on the map.

See: osm.wiki/Good_practice

115025373 over 3 years ago

It is not for me to say which feature that GNIS node belongs to with any certainty without making a good-faith effort to research it. If you aren't willing to go through that effort, I would suggest leaving it alone so another mapper can do that. You can also use the "note" tag to leave a note for a future mapper such as "Pretty sure this is right based on X,Y,Z".

The cleanup and merger of imported GNIS data is a long term project in the US, and many lakes, ponds, dams, and reservoirs need to be traced where GNIS nodes are located or merged with existing features.

115025373 over 3 years ago

While it's true that there is no dam here, that GNIS node that you deleted should have been moved to the feature it described, which appears to be 600 meters to the east of that point.

115024056 over 3 years ago

This issue has been escalated to the Data Working Group. Ticket# 2021121610000167

Issues:
1. Repeated deletion of features which exist in reality
2. Changeset comments which hide the true actions/intent of the change

115022294 over 3 years ago

Restoring deletion of objects that exist in reality is a standard and accepted practice.

115012078 over 3 years ago

Please don't remove valid data. I've reverted this change.

114929944 over 3 years ago

Should be just "New York"

114764596 over 3 years ago

So this:
osm.wiki/United_States/2021_Highway_Classification_Guidance
is gaining rapid acceptance, and is in some stage of implementation for about half the states. Granted, the mid-Atlantic is underrepresented in that effort, but with your help we can change that. In that context, I wouldn't want you to go through wasted effort classifying roads given the major national conversation that is happening regarding highway classification (both on Slack and several threads that have happened on talk-us). There is also a talk planned at the national conference in Tucson on this topic. So it's kind of a big topic at the moment.

114896992 over 3 years ago

Re: classification, when we worked osm.wiki/United_States/2021_Highway_Classification_Guidance in other states, one of the things we did was to de-trunk roads that were parallel alternates to motorways, considering the combined trunk/motorway network as a coherent entity. There's still some question about whether that is still the right approach in big cities (DC definitely counts) so it's kind of an open question. That's why I really think we need to sort out some kind of agreement on Virginia (see link to 23 other state implementations in wiki link above) so that there's no question on the trunk/primary distinction -- we can just run around upgrading and downgrading according to that standard.

114896992 over 3 years ago

Around West Falls Church, there's an intersection between US-50 and the Capitol Beltway - that's the intersection I'm talking about.

114798640 over 3 years ago

The roads that go through MD-140 to the other side should maintain primary all the way through in both directions, and don't warrant a link or motorway classifications. Mitchell drive should not have a link road at its intersection with MD-140. Only the two connections to I-795 should be link.

114764596 over 3 years ago

Note that in general most of your classification changes seem to be okay after reviewing recent changes. If we can collaborate, then we'll avoid having to re-do a bunch of work later and everyone will be on the same page as to what the right classifications are.

114896992 over 3 years ago

Good change to fill in the gap. I suspect US-29 east of I-66 should be downgraded to primary all the way to Arlington since it's paralleled by I-66. I would also downgrade the section of US-29 that runs through the cloverleaf intersection with 495 to match the surrounding road, since a single intersection doesn't qualify a road as motorway.

114896914 over 3 years ago

Good change. I would extend the trunk routing all the way to US-460 through Pearisburg.