OpenStreetMap logo OpenStreetMap

Changeset When Comment
163916411 5 months ago

Re: osm.org/way/1370057429

Hello golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

163885201 5 months ago

Hello golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

163921585 5 months ago

Hey Zach, please go back to the notes I left on a previous change from you last week (osm.org/changeset/163446770). You are crossing greens and fairways and shouldn't be. Please examine the wiki pages and make sure you aren't creating greens and fairways that intersect like in osm.org/way/834709162. Please leave a comment here so I know that you got this message. Thanks.

163881705 5 months ago

Please don't create lollipops like on hole 5 (osm.org/way/1369777434). Use multipolygons to properly create enclosing features instead. See my previous comments and wiki reference on how to create those. Again, feel free to reach out for help if you don't understand. Thanks.

163879948 5 months ago

Hi there JHornberry, as I pointed out in a previous changeset comment (osm.org/changeset/162903940), you are breaking multipolygon relations when you delete and recreate fairways that are part of a relation. Please see the wiki at osm.wiki/Relation:multipolygon#iD for help in understanding how to deal with multipolygons. Feel free to reach out here if you don't understand something. Please respond here so I know that you've seen this message. Thanks!

163866233 5 months ago

Re: osm.org/way/1369677169 ...

Hello golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for visual examples and instructions on how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

163811983 5 months ago

Thanks for joining the fairways and greens. Much appreciated.

163754940 5 months ago

Hey there Thockey,
On hole #5, it's probably best just to join the fairway and the green together and share nodes between them since there isn't a clear break between the two. See osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls for examples of how to map them. Thanks.

163783038 5 months ago

Hello fellow golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for visual examples and instructions on how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

163740212 5 months ago

Hi Zach, why are you creating a multipolygon out of two lines (typically most of the fairway on one line and then a short chunk of line that completes the fairway for the other?) Is there something I'm missing? I don't see any use for a multipolygon in that situation.
For example: osm.org/way/1368431473

163714996 5 months ago

Hello fellow golf course mapper. If you can't see any fringe around a green, you shouldn't reuse the nodes around the entire green, but instead cut the green out of the fairway polygon and reuse them on the boundary between the green and fairway instead. Please read the wiki for visual examples and instructions on how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

163662516 5 months ago

You shouldn't be using the "lollipop" style of mapping as seen in osm.org/way/1367951144. You need to create proper multipolygon relations in order to map features like roughs/bunkers that are within other features. Please see osm.wiki/Relation:multipolygon and osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls for help in understanding how to map this situation. If those aren't clear, please let me know and I'll help explain them further. Thanks.

163633938 5 months ago

Hello fellow golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for visual examples an instructions on how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

163653489 5 months ago

Hey there Matthew,

Thanks for your golf contributions. We appreciate your help.

I wanted to point out a small error in what you are doing. An example is the multipolygon relation osm.org/relation/18829142. I believe you were the one to turn the fairway and green into a multipolygon. That's awesome and much appreciated. But you left the fairway tag on the outer polygon which duplicates the tag on the relation itself and also means that everything inside that outer (including the green) is a fairway, which isn't right. Whenever you make a relation, you need to make sure the outer polygon isn't tagged as well. Let me know if this doesn't make sense. Thanks!

163633261 6 months ago

You shouldn't be using adjoining polygons to define a single feature like a fairway in hole #3. You should just use a single feature for the fairway, a single feature for the green, and then select them both and right click and select merge to make it a single object called a multipolygon.

If you need help, please check out the wiki at osm.wiki/Tag:leisure%3Dgolf_course

If you need help after that, please drop a comment here or reach out to me for help.

163609736 6 months ago

Thanks for helping out with this MapRoulette challenge!

163629479 6 months ago

What exactly are you trying to troubleshoot? Maybe I can help.

163508500 6 months ago

Hello fellow golf course mapper. The lines that define Fairways and Greens should never intersect or partially overlap each other and we noticed that they are overlapping in one or more of the fairway/green pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for visual examples an instructions on how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks!

163289790 6 months ago

The lines that define Fairways and Greens should never intersect or partially overlap each other. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create
them with your map editor). If there is no obvious fringe, the fairway should butt up against the green and every node between them should be shared. Please read the wiki for visual examples an instructions on how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any
questions, please reply here and I'll gladly help clarify things. Thanks!

163469108 6 months ago

The lines that define Fairways and Greens should never intersect or partially overlap each other. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See
osm.wiki/Relation:multipolygon for how to create them with your map editor). If there is no obvious fringe, the fairway should butt up against the green and every node between them should be *shared*. Please read the wiki for visual examples an instructions
on how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls