b-jazz's Comments
Changeset | When | Comment |
---|---|---|
167581448 | 2 months ago | Oops |
167448932 | 3 months ago |
The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. You need to make features wrap around others. For example, the fairway should either fully enclose your tee box, or should fully wrap around it (sharing nodes at the boundary is okay). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
167441869 | 3 months ago |
As pointed out in a previous comment on one of your changes (osm.org/changeset/167156687), golf course elements like fairways, greens, water hazards and the like shouldn't intersect each other. That's one problem. Another is that you drew a fairway here when another fairway already existed. I'm not sure why you're doing that, but clearly that is not the right way to map something. Please see the previous comments and make sure you don't overlap elements in this and future changes to golf courses. Thanks. |
167467461 | 3 months ago |
The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
167292689 | 3 months ago |
The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
167276163 | 3 months ago |
The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
167251322 | 3 months ago |
The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
167234314 | 3 months ago | I just ran a database query for the US to find out how many streams cross greens and fairways. There are hundreds of them (if not more). It seems highly unlikely that a stream is going to cut straight through a bunker or across a green. No grounds crew or course designer would allow that in my experience. See osm.org/way/41511216 for example. |
167234314 | 3 months ago | Thanks for cleaning up the boundary between the fairway and the green. The same type of boundary rules apply to the boundary between fairways and bunkers like osm.org/way/1391822912. You can either share nodes between the bunker and the fairway, or you can leave a gap like was done with the bunker on the opposite side of the fairway. Whichever you feel is appropriate. Thanks! |
167156687 | 3 months ago |
Hello HobbieWoman, Welcome to OpenStreetMap. Thanks for contributing changes and working to improve the map. The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
167134622 | 3 months ago |
The lines that define fairways, greens, bunkers, water hazards, and tees should never intersect (partially overlap) each other and we noticed that they are overlapping in one or more of the feature pairs in this changeset. If there is no obvious fringe around the green, the fairway should butt up against the green and every node between them should be *shared*. If there is a fringe around the green that is similar to the fairway, the fairway should extend around the green and the two objects should be merged together into a multipolygon (See osm.wiki/Relation:multipolygon for how to create them with your map editor). Please read the wiki for instructions and examples of how to better map golf courses: osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls. If you have any questions, please reply here and I'll gladly help clarify things. Thanks! |
167076910 | 3 months ago | Hello VLD549, I'm not familiar with that and didn't make the name change you refer to. What you need to do is refer to the nodes history and find out which version made the change and ask the author that question. The change I made was unrelated to the name. Here's a link to the history: osm.org/node/608656939/history |
167017844 | 3 months ago | RE: osm.org/relation/8481981 (and others) Thanks for helping map golf courses. There are some problems with your edits however and your mapping process needs to be fixed going forward so you don't continue to step on the efforts of others. For starters, you should read the following wiki: osm.wiki/Keep_the_history on how important it is to *not* delete map elements when you should be modifying them instead. You break multipolygon relations when you delete something like a fairway that belongs to a relation only to redraw it and not properly add it back to the existing relation. You should also read the golf_course wiki (osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls) and the general wiki on how to properly work with multipolygons (osm.wiki/Relation:multipolygon#iD). Thanks. |
166843853 | 3 months ago |
As has been pointed out several times before: fairways and greens (and many other combinations of golf course elements) should *not* intersect each other. Please see previous changeset comments for instructions on how to properly map golf courses. https://resultmaps.neis-one.org/osm-discussion-comments?uid=20807485 |
166796036 | 3 months ago | Thanks for helping map golf courses. There are some problems with your edits however and your mapping process needs to be fixed going forward so you don't continue to step on the efforts of others. For starters, you should read the following wiki: osm.wiki/Keep_the_history on how important it is to *not* delete map elements when you should be modifying them instead. You break multipolygon relations when you delete something like a fairway that belongs to a relation only to redraw it and not properly add it back to the existing relation. You should also read the golf_course wiki (osm.wiki/Tag:leisure%3Dgolf_course#Common_mapping_pitfalls) and the general wiki on how to properly work with multipolygons (osm.wiki/Relation:multipolygon#iD). Thanks. |
166707070 | 3 months ago | Ah crap. My bad. |
166643875 | 3 months ago | Thanks! |
166666693 | 3 months ago | Oops. Wrong description... Cutting down high node-count ways that make it more difficult for newer users to refine the ways without bumping into length limitations and getting confused by editing multipolygons/relations. |
166666748 | 3 months ago | Oops. Wrong description. Cutting down high node-count ways that make it more difficult for newer users to refine the ways without bumping into length limitations and getting confused by editing multipolygons/relations. |
166579799 | 3 months ago | I've reverted the changes to this golf course. Your changes have deleted the history of previous ways and are rather sloppily drawn that don't seem to match reality and intersect many other features. Please refrain from mapping courses if you can't follow accepted, standard mapping techniques.
|