I've been having a bit of a tinker with the changeset browser pages (e.g.) this evening, trying to improve them a little. It's great to have the browser as a reference, but it's not always easy to pick out objects that have tags on them unless they have a name tag, which would highlight them. For example, picking out nodes in a highway way that have traffic lights on them.
By getting rails to add some CSS classes, generated based on a subset of popular tag keys - such as amenity, shop, railway, highway, etc. - and their values to the links, a stylesheet could insert icons either as a generic icon for that tag key, or a more specific one for a particular key=value pair where available. The icons could be the same as the ones used in Mapnik for a bit of consistency, and would also allow for this same behaviour to be exposed in the data browser pane on the map.
The links would look something like:
<a href="/browse/node/296615763" class="node amenity restaurant">Gaucho Grill (296615763, v2)</a>
.. and the CSS something like:
a.node { padding-left: 20px; }
a.node.shop { background: transparent url(shop.png) no-repeat center left; }
a.node.amenity.restaurant { background: transparent url(restaurant.png) no-repeat center left; }
Is this something that people may be interested in seeing?
Diskussion
Kommentar von rurseekatze am 6. März 2010 um 08:00 Uhr
Really good idea! It wasn't so user-friendly until now and I often was in a situation, where I first had to look into the details of each node to know which type it is. This feature would be very useful!
You should mention this on the wishlist for the new OSM main page!
Kommentar von Gnonthgol am 6. März 2010 um 08:11 Uhr
Wow, this looks amazing. Just make sure it does not hit performance to much.
Deploy asap.
Ideas for improvment:
Icons on ways as well.
It would be nice to see what way(s) a node belongs to on the same page.
Kommentar von lyx am 6. März 2010 um 09:24 Uhr
I really like it!
Kommentar von rendle am 6. März 2010 um 12:52 Uhr
Would be nice.
Kommentar von Siren Torsvik Ornes am 6. März 2010 um 13:20 Uhr
This would be really nice!
Kommentar von robert am 6. März 2010 um 15:28 Uhr
Any improvements to the changeset browsing are good.
Kommentar von Skippern am 7. März 2010 um 19:27 Uhr
This improvement looks good, both visually and technically. Hope that the RoR part is just as slick so we can have this up and running soon. It will be a great benefit for us who are trying to maintain large areas.
Kommentar von dankarran am 7. März 2010 um 19:41 Uhr
I don't actually have a working rails port site set up to hack on at the moment, so if anybody fancies implementing it, please feel free. Otherwise, I'll hopefully get it set up soon so I can do it :)
Kommentar von Philip am 7. März 2010 um 20:50 Uhr
Great idea :) Whilst you're in there adding the class attribute, it might be good to drop all the name/value pairs of all the node's tags into the 'title' attribute. Then they would show as you hovered over the link (which could then be progressively enhanced by a bit of js).
Kommentar von dankarran am 9. März 2010 um 14:17 Uhr
I got my test site up and running locally, and the ruby code is working. I need to do some more testing and finish adding the classes in, then I'll propose it as a patch to the site maintainers.
Kommentar von IgnoredAmbience am 16. März 2010 um 16:20 Uhr
I only got a quick glance at wherecamp, how's it going?
Kommentar von dankarran am 16. März 2010 um 19:13 Uhr
It's about ready to go I think... The patch is on Trac ticket #2787 if you would like to try it out give any feedback?