Thanks. I also removed the tags addr:city and addr:street for these buildings.

No problem (sorry to answer so late).

Thanks for your contributions.
As Thorntons (Edinburgh) was already mapped, I merged your information with the existing one and added more information for this shop.
I updated also the information about the Royal Mile Market as it isn't a supermarket but a market (amenity=marketplace).
Hope it's ok and thanks again for your contributions.
marketplace

The name of this place is The Hebrides, not "The Doric". The latter is next door and already mapped.

Hi Tom, I amended this tree as Leyland cypress isn't its name but its species. I also updated the denotation.

Thanks GinaroZ. It has been corrected by another contributor here: osm.org/changeset/45714170
Then I improved because Whitehouse Terrace is for North Side and Grange Loan is for both side, even if there is no number in the North part.
For info, matt76x, "name:South side" isn't a valid OSM tag. Tags for street names are name, alt_name (which means a strict equivalence between name and alt_name, which isn't the case here), name:left and name:right (left and right being a reference to the direction of the road, i.e. "comparatively to its arrow").

Whitehouse Terrace being part of the north side of Grange Loan, I changed it into name:left as it was originally (i.e. before a contributor changed it into name:South Side). Thanks anyway to have spotted this error.

I finally had the chance to enter there last week and to take some pictures of all the buildings. It's now finally updated.

The name of this street is officially Grange Loan. If you check the list of the CEC public roads, you'll see that Whitehouse Terrace is defined as "Part of the north side of GRANGE LOAN from WHITEHOUSE LOAN
eastwards to KILGRASTON ROAD".
For information, Whitehouse Terrace was tagged and is still tagged as name:left of this OSM highway.

I mapped the old police call box as a building (using the same tags that the other PCBs in Edinburgh). I also mapped what you called triangle as a landuse=grass.

Would it not be better to map these Community Gardens as an area, as they would be visible and the name would appear on the map.

Thanks Donald. I thought it was ok to add them already as buildings because their construction is going to start very soon (less than a month) and because the area is tagged as landuse=construction.

But you're right, it's clearer the way you mapped it. Thanks.

Hi Chris, not sure that these stairs are really private as it's (or at least it was) possible to use them to walk from Blenheim Place to Greenside Row (and vice versa).

Hi wille, thanks for your answer. I agree with what Chris wrote for several reasons: 1. all the approved tags aren't rendered by the default map renderer, 2. the OSM specifications are a kind of foundation to build the OSM database, the default map renderer isn't, 3. the current OSM specifications do not yet covered all the mappable objects so it's good to try pushing some new tags into the OSM specifications, 4. if you use amenity=school, it can lead to some confusions for OSM data consumers/OSM users.

Why not creating a new tag here for this kind of school (even if there is a limited number of them at the moment), e.g. amenity=derose_school or derose_method_school, the same way that amenity=language_school has been created (see the urls above written by SomeoneElse).

What do you think to use two names for these schools: a short one, "DeRose Method" , and a long one (using alt_name), "DeRose Method - New Town" (the same way the names of the supermarkets don't include the neighbourhood in which they are located)?

The number at the gate is 27 and the one associated with the cemetery is 17. 17 seems to be the right one. Just let me know what to do Chris and I'll update it as I have to improve the place in order to merge the two cemeteries (one is a multipolygon named Old Calton Burial Ground and the other one is a polygon named Old Calton Cemetary --> Cemetery) which represent the same entity with different geometries. Thanks.

Agree with GinaroZ so I removed amenity=shop.
The tagging shop=recycling doesn't exist but makes sense here.

As it isn't a hotel, I'm going to change the value of "tourism": hotel->apartment

They probably moved there as the other company at the 22 apparently moved (their website is no longer online). I changed the name into Nordic Visitor, kept the previous one as alt_name and as it isn't a shop, use office=travel_agent instead. As we have to survey Shandwick place soon, we'll check this office (to remember it, I'm going to add a note)

Hi, thanks to let us know about it. These POIs have just been updated.