OpenStreetMap logo OpenStreetMap

Changeset When Comment
46918041 over 7 years ago

You left some untagged ways here osm.org/way/235543455 osm.org/way/235543453#map=19/53.33074/-6.26178

What's going on with them? Maybe best to just delete the ways if the buildings are gone...

52564873 over 7 years ago

Hi! Welcome to OSM. You asked for a review, so here it is.

The only thing you did here was create an outline around Buggar's Bush ( osm.org/way/529472692 ), but you didn't put any tags or anything on it, making it invisible to everything. I've removed it, since it's not doing anything.

If you say what you wanted to map, I can help you

54631165 over 7 years ago

Hi. Welcome to OSM! You asked for a review, so here it is.

This is mostly pretty good. There's a few newbie mistakes. You entered the playground ( osm.org/way/546875187 ) as "leisure=park" which is more for a regular park. We have "leisure=playground" for an actual playground with swings and such ( osm.wiki/Tag:leisure%3Dplayground ). There's lots of ways to tag the equipment ( see here osm.wiki/Key:playground ). You entered a "name" of "childrens playground". That looks like a description, not a name. We shouldn't put descriptions in the name. If it doesn't have an explicit name, then it's best to leave that empty.

I'm a little confused by this ( osm.org/node/1130217277 ). It was entered as a firestation, and you've drawn the play ground around it, but you've then changed it to a playground again. From the aerial imagery, it looks like a playground, not a firestation, so that looks right (I've asked the original mapper to have a look over osm.org/changeset/7150828 ). However now there are *2* playgrounds! It's best to only have one OSM object when there's only one thing in the real world. Don't be afraid to just delete a thing if it's not there anymore! You can always request a review if in doubt.

Good job on adding the restaurant. Did you know you can auto-square buildings? (Press S I think). It more accurately matches reality. And it looks nicer. 🙂 Is the name really "The mill" with a small m? If not, change it to a big M.

Would you like me to do the fix ups I mentioned, or do you wanna take a whack at it?

7150828 over 7 years ago

Hi, you entered a firestation in Mountmellick ( osm.org/node/1130217277/history ), but from the aerial imagery it looks like there's nothing there. And someone has just drawn a playground around it (which matches the aerials). Is that right? Is this a firestation or is that gone now?

53593921 over 7 years ago

Hi! You added a long terrace on the sea front in this changeset. However you made a mistake with splitting it up. You shouldn't put the untagged ways in the middle. It's better to make lots of buildings, which are glued together.

JOSM's terracer plugin can make this easy.

54609125 over 7 years ago

Hi! You asked for a review, and similar to that last changeset ( osm.org/changeset/54609113 ), you've got the mapping for the tree a little wrong.

54609113 over 7 years ago

Hi, Welcome to OSM! You asked for a review, so here it is.

You've added on object in this change ( osm.org/node/5282837222 ), and er, that's not quite right. In OSM we use the "name" tag for, well, the name of things. And we need some extra tags to explain *what* the thing is.

If you want to map a tree in OSM (there are ~10 million mapped already!), you should use the natural=tree tag. It's best to use the presets option in iD, that'll tell you the right one. If you type in 'tree' to that, it'll select the correct values.

So if you change that point to be like that, then this is good.

54549808 over 7 years ago

It is written on the "note" of the node! 😉😉

54549808 over 7 years ago

You asked for a review, so here it is. Nothing wrong with this. The GNS data is a bit hairy, it's good to clean it up as you go along.

I think most geocoding software won't actually use those tags to figure out the county, so it was unlikely to have broken anything. 🤷

Still, good to have it fixed. 👍

5155134 over 7 years ago

The original value from 7 years ago was "280m", and 280 feet is 85 metres. 🤷

54468124 over 7 years ago

It looks like that value of 280m was added in 2010 by pf_irl ( osm.org/changeset/5155134 ), I've left a comment on that changeset.

5155134 over 7 years ago

Hi, you added a point for "highest point in tory island" (this point: osm.org/node/804468936 ), and it has lately been changed in this changeset ( osm.org/changeset/54468124#map=16/55.2632/-8.1925 ), saying that the elevation value was probably wrong.

54431820 almost 8 years ago

Hi! Welcome to OSM. You asked for a review of this change, so here it is.

I'm afraid you've made a bit of a mistake with this building ( osm.org/way/545257648 ) by putting it on top of what's marked as a road in OSM ( osm.org/way/70755936 ) from looking at the aerial imagery, that road it wrong so I'll have to remove that. Don't be afraid to remove things like that which are wrong!

You also added a little "landuse=residential" here ( osm.org/way/545257647 ), it looks like a building to me. You only use landuse for things like housing estates, not individual buildings.

54414656 almost 8 years ago

I might take a look later, see if I can clean it up a little

54414656 almost 8 years ago

Hi! Welcome to OSM! You asked for a review of this edit, so here it is.

You're right, this *is* 2 "paths" on the top and the bottom. (I was there recently).

You've added `footway=sidewalk` to the path, and I don't think that's right, since it's not a path beside a road you can drive on. I'd suggest `highway=pedestrian`, since it's quite wide. (A good rule of thumb for OSM: It's a `highway=pedestrian` if you physically could drive a car on it, but you're legally not allowed. Or alternatively, could 4 people walk abreast on it. In this case, yes)

I dunno how to properly tag that the area is all walkable..

54397399 almost 8 years ago

Hi! Welcome to OSM! You asked for a review, so here it is.

This looks good. You've added some details to the new coastal trail (like width/lit/etc). You've connected the path to the road, which is important for topology/routing.

You have the path going slightly into the sea at the coastline corner in the middle. I've nudged the coastline a bit so your path stays on solid ground. :)

Keep mapping, and have fun. :)

54366808 almost 8 years ago

Hi! Welcome to OSM! You asked for a review, so here it is. This looks like a fine edit. Adding some footways, and you've correctly ensured they are connected to the roads (which is important for routing).

The building you added looks fine. If you know more details of the building (like what sort of buidling it is, or it's name) that's always good to add. You can press S to make the building be more right angled, which is more accurate for how buildings actually are.

54291990 almost 8 years ago

Welcome to OSM! This looks like a nice edit, making the map better. :)

54298586 almost 8 years ago

Hi! Welcome to OSM. In this changeset, you said you added an irish name", but I can't see any Irish name on this road ( osm.org/way/61942637 )

54301475 almost 8 years ago

Does it make sense to add a name tag to a stretch of coastline? Do you mean to add the name of the island? There already is the name on the townland ( osm.org/relation/6836983 ) so i don't think you need another name here?