OpenStreetMap logo OpenStreetMap

Changeset When Comment
55934512 over 7 years ago

Hello and welcome to OSM! You asked for a review of this changeset.

This change looks fine. It's always good to have more houses entered (despite the project being called Open STREET Map, it actually has much more buildings than streets).

The web editor (iD) has the ability to square building corners, to make them right angled, which is what they are in the real world. It can make the map data better.

I'll have to look at the aerial imagery later, but if you have a semi-d house, or a terrace, then it's better in OSM to split that into 2 buildings which share a wall. This allows you to put separate tags for (say) housenumbers on each one.

55934447 over 7 years ago

Hi, You asked for a review, so here it is.

Thanks for this edit. Lots of good stuff here, with lots of details. 👍🙂

You've added a node (point) here ( osm.org/node/5375514911 ) for a basketball court. However you put it inside a way (area) of an existing basketball court (this one: osm.org/way/256113545 ). It's better to have sports facilities like that (pitches) as areas, not points. Since they are areas in real life, and with decent arial imagery you can usually see where the actual court outline is. It's also not good to have 2 things when there is only one basketball court, you should probably remove the node/point you added.

I notice you added `hoops=2`. 🙂 As you have figured out, OSM has a flexible tagging system, so you can make up your own tags, there's no central authority. But I dunno if we need to specify that there is 2 hoops (since that's what one bastketball court usually has).

Information on lighting and building sizes is very helpful, again it's data that's hard to get. So thanks for adding it.

55934043 over 7 years ago

You've also moved a post box to the other side of the street. Which is OK, but a little odd. Did An Post remove the one beside the dry cleaners? If there are actually 2 post boxes (one near the dry cleaners, the other where the node now is), then you should have 2 postboxes in OSM. 🙂

You've also done a kinda weird thing of "merging"/"glueing" the postbox to the corner of this building ( osm.org/way/227934966 ). It's almost certainly wrong to glue a postbox there. When somethign is "part of the wall" you "glue"/"attach" it like that. So doors or things are "glued". But if the postbox is freestanding, then you should just have it as a separate, free standing, node in front of the building. Can you stand between the postbox and the building? If yes, then it should be separated. if no (i.e. postbox is built into the wall), then what you've done is right.

55934043 over 7 years ago

However, there are one or two simple, and common, beginner mistakes. You added the Applewood vets ( osm.org/node/5375493810 ), and for the phone number it's better to put it in in "international format", i.e. "+353-1-...". Then it's usable to anyone in the world without them needing to know about Irish phone numbers.

You added the opening hours, but there's a "proper" format for opening hours ( osm.wiki/Key:opening_hours ). If you use that, then apps can use it (e.g. OSMAnd can show you that). The format can be complicated due to all the special cases, but you can use a page like YoHours ( http://projets.pavie.info/yohours/ ). You just graphicaly select the hours and then copy/paste the opening hours text at the top.

I've changed those details on that vets now, You can see the changes here https://pewu.github.io/osm-history/#/node/5375493810

55934043 over 7 years ago

Welcome to OSM! You asked for a review for this, so here it is.

It's good that you're adding POIs, things that can only be added by someone on the ground. Please continue to add more of them. 👍😃 It's also get to get more details, phone numbers, opening hours etc.

55934997 over 7 years ago

Welcome to OSM! You asked for a review so here it is.

This looks fine. :) It's always good to have Points of Interest (POI) like shops. We can't get them from aerial imagery. It's good that you put in a little bit more details, rather than just "shop=yes" or something.

You can always add more details, phone numbers, opening hours, eircodes, etc. :)

55847110 over 7 years ago

Hi there. Welcome to OSM!You asked for a review, so here it is.

I'm a little confused by this. You've added a (weirdly shaped) pond in a middle of some back gardens. I can't see any ponds there in the Bing aerial imagery. What's going on?

I've removed it in this changeset ( osm.org/changeset/55927886 ).

55844231 over 7 years ago

A review was requested, and for the record, I did this (& the other) on the other changeset: osm.org/changeset/55844257

55844257 over 7 years ago

Hi! Welcome to OSM! You asked for a review on this edit (and the previous one osm.org/changeset/55844231 ), so here it is.

Thanks for adding this, and the house number. We can't get addresses from the aerial imagery, so we need someone local to add them. Thanks for this. 👍

*buuuuut* you added your back garden as `leisure=park`, that's mostly for actual parks maintained by the council and all that. Adding a name of "back garden" is wrong as well, since the name should be the sort of thing that would be on a sign, not just a description. It's OK if something doesn't have a name, lots of things in the real world don't have a sign with the name.

You can also use the 'square' feature to make a building have right angles, which can make buildings more accurate.

55801603 over 7 years ago

Hi, welcome to OSM! You asked for a review, so here it is.

I think you've made one or two newbie mistakes here. You added a part of the path here ( osm.org/way/556245385#map=18/53.34689/-6.52044 ) and you added the `access=no` tag. That's for things which the public aren't allowed on. Private driveways that kind of thing. Is that right? I suppose this is private grounds so it make sense that way. Maybe you should update the other tracks/roads as well.

You've tweaked this little bridge there here ( osm.org/changeset/55801603#map=17/53.34659/-6.52231 ) and sorta joined it at a sharp angle to the new path. Is that right? It looks like the little bridge should be part of the track you added.

Do you know what I mean? Would you like to take a stab at cleaning it up or would you like me to do it?

55787974 over 7 years ago

Hello and welcome to OSM! You asked for a review of this change.

You marked this as "natural=grassland", but that's more for savannah in Africa or something, not a patch of grass in a housing estate! 🙂 I've changed it to landuse=grass which is correct for this.

55695808 over 7 years ago

You asked for a review, so here it is.

This is very good for a new mapper. you're including a lot of details, which is great. eircodes/addresses, opening hours, lots of details on the pub, etc.

The only thing I'd question is the farm buildings to the top right, you added building=farm, but I think that's for "farm houses" (which we don't really have in Ireland I think). I would have mapped those buildings as building=barn. But, if you know the area, then that's fine

16858468 over 7 years ago

I've fixed it hre osm.org/changeset/55741408

55696655 over 7 years ago

Well, are there any houses/buildings there now? If they've all be leveled, then it looks like those numbers are now gone and you can delete them if you want.

55696655 over 7 years ago

You asked for a review, so here it is. This looks fine. You can make areas have "right angled corners" in iD, sometimes that can be more accurate if they have right angled in the real world.

I trust you that these houses have been demolished. *But* there is still some address points there, if they've been demolished, shouldn't they be gone? Is there a number 176 still? a 175? etc.

55696624 over 7 years ago

Hi! You asked for a review, so here it is.

Now, I know the thing you have added. it's a big old, semi-circular, metal yoke, right? It doesn't actually lift the bridge any more, right?

So I don't know really *what* type of thing this is.

Now, OSM has a free form and flexible tagging system, so you're totally free to make up whatever tag you want ( osm.wiki/Any_tags_you_like ). So man_made=Lifting_bridge is as good as anything. Minor note: the OSM convention is to use lower case letters for "machine" tags, so it should be man_made=lifting_bridge here.

You don't need the area=yes tag, since it's a closed area. iD adds them often. It doesn't really matter anyway, since it does no harm.

55692408 over 7 years ago

Hi, you asked for a review, so here it is. I see you did some HOT work in Bangladesh, you haven't changed the commit message. 😉

You have added the name to a crossroads here. Thanks! 😁 It's that sort of local knowledge that we need.

*But* you just put the name on the point (i.e. "node" in OSM-speak). So much software (incl the software which makes the map on osm.org) won't do anything with it. If you add the "junction=yes" tag, then it'll appear on the map. Would you like me to do it? or do you want to have a go at it?

Here's an example of the way to do it: osm.org/node/1496772129

16858468 over 7 years ago

Hi! In this change, you added a way here ( osm.org/way/229044998#map=17/52.13806/-7.04833 ). But there's no tags! :) I presume this was a simple mistake. From your comment, and the aerial imagery, it looks like a cliff path. Would you care to add that detail yourself? Or would you like me to do it?

55602280 over 7 years ago

You asked for a review, so here it is.

I'm not 100% sure about the right way to tag woods and such. The OSM Wiki documents 6 different approaches and tagging schemes ( osm.wiki/Forest )! 🙂

Anyone who uses OSM data should take them into account, so your "natural=forest" seems right.

55651526 over 7 years ago

You asked for a review, so here it is.

This looks fine. You have added one house, which I can see in the aerial imagery. There are a few houses there, why not add the rest? 🙂