OpenStreetMap logo OpenStreetMap

Changeset When Comment
54220267 almost 8 years ago

You asked for a review, so here it is.

Firstly you changed the lane to `building=residental`, which is wrong. All the buildings are mapped, so it would be better to delete the way itself.

54230565 almost 8 years ago

Hi! Welcome to OSM! You asked for a review, so here it is.

This is perfectly fine. Nothing wrong here. 👍

In OSM we can add more detail than just the building. In this changeset ( osm.org/changeset/54231514 ) I have added an `amenity=fuel` object inside this, this tells people that this is actually a filling station. This can allow people to find it. 🙂

54211366 almost 8 years ago

You asked for a review, so here it is.

I was in the area recently and went through this junction. It has been changed from a roundabout to a regular intersection, so this looks good

54200132 almost 8 years ago

You asked for a reviewof this edit, but surely an OSM note would be more appropriate

42828128 almost 8 years ago

Hi! You changed a few tags from building=yes to landuse=farm here. which isn't right. "landuse" tags are for, well, landuses. Buildings are on land. :) So you should keep the building=yes tag. I've fixed it up

54069728 almost 8 years ago

You requested a review, so here it is.

This looks good and fine. 3 buildings mapped well. You added building=house which is more detailed (ie better) than just building=yes. iD (& JOSM) have a 'make right angled' feature, which is good for buildings

You missing the extension on the house on the left.

53900905 almost 8 years ago

Hi! Just a note: You added a few stones but forgot to add a natural=rock tag to them, which means it couldn't be used. I've added that tag to them here, I took a guess that they were all rocks. osm.org/changeset/54044837

51794236 almost 8 years ago

Hi, you added some buildings here. I've fixed up the duplicate smaller building on the behind the house

46768321 almost 8 years ago

Hi, you added a large square landuse=farmland (and a smaller area=yes area) in this change.

I'm not sure what you were trying to do here, but it's not great mapping... I have removed them here osm.org/changeset/53872232

53832524 almost 8 years ago

Hi. I noticed you added some addr:place=Swords here (and in other changesets). Are you sure that's right? I don't really know much about addr:place, but the docs on the wiki ( osm.wiki/Key:addr:place ) say it shouldn't be for places which also have an addr:street, which some of these have. Also Swords is a town/suburb, which the docs imply is not the same thing as a place...

19010494 almost 8 years ago

Hi, you added a lot of areas in this edit without any tags, you just had the default area=yes tag, which doesn't really change anything. I've removed most of them in this changeset ( osm.org/changeset/53801299 ).

We don't *really* map fields in OSM. You can always map the walls/hedges if you'd like.

48578628 almost 8 years ago

Hi, you added a few untagged nodes in this changeset. I'm not sure what they are, but I've removed them here osm.org/changeset/53778538

45715225 almost 8 years ago

Hi, you've mapped a lot of cars in this edit. I'm afraid we don't map cars in OSM, they tend to move around ;)

53262990 almost 8 years ago

Review requested, so here we go.

I'm not so sure about this edit. You've changed the "place" node, which is for, well, the village. Adding the Wikipedia link is fine. But the tourism tag is wrong. It's not for a listing of things that are available like that.

OSM Is geographical, so we're able to know that the copper mine musuem is in this village, so you don't need to add it. It's better to add the sandy beaches as beaches, likewise walks.

53262891 almost 8 years ago

Review requested, so here we go. Another good edit. Lots of nice detailed information, like contact details for phone & website. International phone numbers are best (I might go through and fix that up sometime)

53262576 almost 8 years ago

Review request, so here we go! Another good edit. Lots of local data here. Like the last edit, you don't really need the addr:city because of Irish addresses. It's good you added the community hall.

53262368 almost 8 years ago

You requested a review, so here we are. Another good edit. Lots of good, local knowledge info added here.

Few points: The "operator" tag is really used for things like "What bank operates this ATM?" (Important for possible ATM fees), or "What bus company operates this route?". It's not really for the name of the people who run the shop. And it can be a little privacy invasive to put that in! :)

Again, adding extra details is better than putting things in the description. But putting it in the description is better than nothing, since it means someone else can fix it up later.

The phone number should be in international format, since OSM is a global database.

You have a bit too much info in the "addr:city" field. We can figure out it's in Co. Cork! TBH the only real useful address information is (if applicable) the street + number (or street + housename). But Irish addresses being what they are, that can be rare out in the country. If you know the Eircode, that's good to put in in the addr:postcode field.

53263833 almost 8 years ago

You requested a review, and I've covered it in the review of the other changeset ( osm.org/changeset/53262165 ), this node should probably be deleted

53262165 almost 8 years ago

(Oh, and welcome to OSM!)

53262165 almost 8 years ago

You requested a review of this change, so here we go.

This broadly looks pretty good. Local knowledge is good for OSM, and what it's all about. You've added a few important details to the pub. We don't need the description really, since no-one uses that. It's better to come up with proper tags to add that (There is a 'real_fire' tag which might be what you want osm.wiki/Key:real_fire ). When you add a regular building you can press S (I think) and it'll make the angles 90degrees which is accurate and nice.

The biggest problem is that you've added this pub again later! In this changeset ( osm.org/changeset/53263833 ) you add it again as a node (ie point). You shouldn't have it in twice, since then it looks like 2 pubs. If the pub takes up the whole building, then what you've done here is right, and you should delete the other one.